Cleanup deprecated InterpolationMethodMap #2041
Conversation
github-actions
bot
requested review from
MarqRazz,
Maverobot,
arne48,
fmauch and
saikishor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2041 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 148 148
Lines 14367 14367
Branches 1230 1230
=======================================
Hits 12200 12200
Misses 1740 1740
Partials 427 427
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
added
the
hold
christophfroehlich
changed the title
fmauch
left a comment
fmauch
left a comment
There was a problem hiding this comment.
The change itself seems fine, but what is the policy on deprecating this? Having only one sync in between seems less than what we used to do previously.
Yes, we will have to hold it for sometime |
|
Yes, I also think so. We should wait few release syncs before cleaning it up. 👍 |
|
Yes, that's why I labeled it as hold but will likely merge it once the deprecation got synced. |
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
4 participants
Hello, respected maintainers, and reviewers!!
Again, this is Surya :)
This follow-up PR on interpolation_methods.hpp, cleans up the deprecated
InterpolationMethodMap, for the next release cycle.This PR addresses,
InterpolationMethodMap.